Problematic port field in struct ip_service in Samba.
asn at samba.org
Fri Jul 17 05:58:38 UTC 2020
On Friday, 17 July 2020 00:26:00 CEST Jeremy Allison via samba-team wrote:
> Hi Team & all interested parties,
> Eventually I'd like to replace all
> uses of struct ip_service -> struct sockaddr_storage,
> but that's a bigger cleanup for another
> day.. :-).
we actually should replace this with `struct samba_sockaddr`
to avoid strict aliasing issues!
See lib/util/util_net.h for `struct samba_sockaddr`
I've just recently had to fix a crash on arm in nss_wrapper which was caused
by not following strict aliasing rules:
Andreas Schneider asn at samba.org
Samba Team www.samba.org
More information about the samba-technical