PATCH: make disabling of vfs_snapper consistent with our configure/build system

Stefan Metzmacher metze at samba.org
Fri Jul 10 18:31:32 UTC 2020


Hi Björn,

> On 2020-07-10 at 13:22 +0200 Ralph Boehme via samba-technical sent off:
>> Am 7/10/20 um 1:07 PM schrieb Björn JACKE via samba-technical:
>>> can someone pleae review and push eventually?
>>
>> How does this relate to the discussion in
>>
>> https://lists.samba.org/archive/samba-technical/2020-May/135241.html
>>
>> that resulted in commit 7ae03a19b3ca895ba5f97a6bd4f9539d8daa6e0a ?
> 
> configure --help says (among lots og other things):
> 
>   --with-shared-modules=SHARED_MODULES
>             Comma-separated list of names of modules to build shared. May include !module to disable 'module'. Can be '!FORCED' to disable all non-required
>             shared only modules. Can be '!DEFAULT' to disable all modules defaulting to a shared build. Can be 'ALL' to build all default static modules
>             shared. The most specific one wins, while the order is ignored and --with-static-modules is evaluated before --with-shared-modules
> 
> 
> That information was obviously missed in that discussion above.

I don't see why your change would be needed, I actually think it makes
the situation worse, as --disable-snapper is no longer available
and configure would just fail if dbus-1 is not available.

metze

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20200710/75b94d6f/signature.sig>


More information about the samba-technical mailing list