PATCH: verbose mode for smbclient tar
bj at SerNet.DE
Tue Jan 14 10:13:49 UTC 2020
On 2018-01-04 at 12:50 -0800 Jeremy Allison sent off:
> On Thu, Jan 04, 2018 at 12:20:58PM +0100, BjĂ¶rn JACKE via samba-technical wrote:
> > On 2018-01-03 at 23:43 +0100 BjĂ¶rn JACKE via samba-technical sent off:
> > > On 2018-01-03 at 17:17 -0500 Jim Brown via samba-technical sent off:
> > > > isdir is uninitialized for all non-directory items.
> > > > isdir should be initialized and then used the if statement.
> > >
> > > thanks, attached fixed!
> > one more with a minor documentation fix on this for the new v switch.
> > Bjoern
> The "normal" status messages produced from clitar should be printed
> using d_printf() instead of a DBG() (which maps internally to a
> DEBUG() statement).
> I know clitar.c currently messes this up by mixing printf() and DBG() -> DEBUG()
> but moving forward we should try and clean this up by moving printf() to d_printf()
> and ensuring that only internal status messages (which may be part of the
> 'verbose' stream) go out using DEBUG().
> If you don't have time for this now, let me know and I'll review the
> patch as-is, but eventually we need to fix this up correctly (we can
> do it as a patch on top if you prefer).
done now, see: https://gitlab.com/samba-team/samba/merge_requests/1052
More information about the samba-technical