Samba coverage on oss-fuzz (was: Re: fuzzers)

[Andrew Bartlett]

On Fri, 2020-01-17 at 07:58 +1000, Andrew Bartlett via samba-technical
wrote:
> On Thu, 2020-01-16 at 11:08 +0100, Andreas Schneider via samba-
> technical wrote:
> > On Thursday, 16 January 2020 10:58:24 CET Andreas Schneider via
> > samba-
> > technical wrote:
> > > Hello,
> > > 
> > > thanks to all people who worked on fuzzing Samba. This is a great
> > > addition.
> > > 
> > > However before we add *more* fuzzers, it might be a good idea to
> > > first fix
> > > the bugs found by the fuzzers ;-)
> > 
> > Also the build is failing since weeks:
> > 
> > Step #3: /src/samba/lib/fuzzing/oss-fuzz/build_samba.sh: 42:
> > /src/samba/lib/
> > fuzzing/oss-fuzz/build_samba.sh: SANITIZER_ARG: parameter not set
> > 
> > 
> > The attached patch should fix it.
> 
> Thanks, I seem to have misunderstood how the coverage build works.  
> 
> What is SANITIZER set to in this case?
> 
> Does this pass the coverage test in the oss-fuzz repo?
> 
> https://google.github.io/oss-fuzz/advanced-topics/code-coverage/
> 
> To test, change the projects/samba/Dockerfile to point at your branch
> to test:
> 
> 
https://github.com/google/oss-fuzz/blob/master/projects/samba/Dockerfile#L19
> 
> The 'infra/helper.py shell' command can be quite helpful debugging
> this
> stuff.

I looked into this some more, and the build seems to be working on the
Samba side, but the issue is that because we supply no fuzz seeds at
all, we fail the test because they don't get run.

Once we add some seeds things should get better.

Andrew Bartlett

-- 
Andrew Bartlett
https://samba.org/~abartlet/
Authentication Developer, Samba Team         https://samba.org
Samba Development and Support, Catalyst IT - Expert Open Source
Solutions
https://catalyst.net.nz/services/samba