[PATCH] Add support for getting and setting SACLs

Shyam Prasad N nspmangalore at gmail.com
Wed Dec 2 10:43:39 UTC 2020

Hi Boris,

At a high level, the changes look good to me. Will go through the
changes in more detail tomorrow morning.

On a related note, we may need more test coverage in this area.
Can you please share your testing output against your changes?
Or even better, if you can contribute some xfstests for this use case:


On Wed, Dec 2, 2020 at 12:24 AM Boris Protopopov
<boris.v.protopopov at gmail.com> wrote:
> Hello,
> I am checking in to see if anyone had a chance to take a look at this
> patch. I would appreciate any feedback.
> Thanks!
> On Tue, Oct 27, 2020 at 5:01 PM Boris Protopopov via samba-technical
> <samba-technical at lists.samba.org> wrote:
> >
> > Add SYSTEM_SECURITY access flag and use with smb2 when opening
> > files for getting/setting SACLs. Add "system.cifs_ntsd_full"
> > extended attribute to allow user-space access to the functionality.
> > Avoid multiple server calls when setting owner, DACL, and SACL.
> >
> > Signed-off-by: Boris Protopopov <pboris at amazon.com>
> > ---
> ...


More information about the samba-technical mailing list