[PATCH] Remove 'samba-tool user add'

Michael Howard mike at dewberryfields.co.uk
Thu Apr 30 10:43:42 UTC 2020

On 30/04/2020 11:24, Rowland penny via samba-technical wrote:
> On 30/04/2020 11:07, Björn Baumbach wrote:
>>>> Andrew Bartlett via samba-technical <samba-technical at lists.samba.org>
>>>> wrote:
>>>>> Can someone remind me why it was deprecated?
>> On 3/29/17 3:04 PM, Volker Lendecke via samba-technical wrote:
>>> Also, shouldn't we align this with the group commands? There we have a
>>> "samba-tool group add", but no "samba-tool group create".
>> Hi!
>> I would like to continue this proposal and like to read your ideas to
>> resolve this.
>> I've recently opened a merge request with a set of patches which rename
>> the "samba-tool group add" command to "samba-tool group create" and
>> deprecated the add:
>> https://gitlab.com/samba-team/samba/-/merge_requests/1304
>> I planned to fix all other "add" subcommands, but I've noticed that most
>> of the subcommands like computer, contact, ou, ... use "create" already.
>> In addition to the "group add" command there are two further "add"s
>> left, but they make really sense, in my opinion. It's "spn add" to add a
>> SPN to an account (while the command description says "add - *Create* a
>> new spn") and "dns add" to add a DNS record.
>> I think the "add" command is generally more comfortable and seems to be
>> more natural, even for adding new users or groups to the AD.
>> It seems that several people wonder why the "user add" command has been
>> renamed to "user create". Unfortunately the commit message does not
>> provide this information:
>> commit b26a4f6232219746fd8ed1b107476f3c23c6908e
>> Author: Theresa Halloran <thallora at linux.vnet.ibm.com>
>> Date:   Sun Oct 23 15:23:28 2011 -0700
>>      s4: samba-tool subcommand rename - change samba-tool user add to
>> samba-tool user create
>>      Signed-off-by: Theresa Halloran <thallora at linux.vnet.ibm.com>
>>      Signed-off-by: Jelmer Vernooij <jelmer at samba.org>
>> What do you think about:
>> 1.) Just replace the "group add" with "group create" (and keep "dns add"
>>      and "spn add"), like in my merge request.
>> 2.) Have both, "add" and "create", for all subcommands.
>> 3.) Roll-back: Remove the "user add" deprecation warning, add the "add"
>>      command to all other categories and deprecate all "create" 
>> commands.
>> Please let me know :-)
>> Best regards,
>> Björn
> The problem with '1' is that there  will undoubtedly be scripts out 
> there that use 'group add', so you will have to deprecate 'group add' 
> then remove it at a later date and just look at how long it has taken 
> to remove 'user add'.
> '2' will just lead to confusion.
> '3' will mean deprecating 'user create' and this will just lead to 
> confusion.
> I would just remove 'user add'.
I'm not involved in any samba development but from a user perpective, 
especially on unix like systems, 'add' is much more intuitive than 'create'.

I would keep both but that may involve more overhead than developers like.

I don't see why either 2 or 3 would lead to confusion, unless a lot of 
four year olds will be getting samba for Christmas.

Michael Howard

More information about the samba-technical mailing list