[PATCH] cifs: improve read performance for page size 64KB & cache=strict & vers=2.1+

Pavel Shilovsky piastryyy at gmail.com
Mon Apr 13 16:37:38 UTC 2020


Looks good, thanks!

Reviewed-by: Pavel Shilovsky <pshilov at microsoft.com>

--
Best regards,
Pavel Shilovsky

вс, 12 апр. 2020 г. в 19:23, Jones Syue <jonessyue at qnap.com>:
>
> Hello Pavel
>
> Thanks for kindly reviewing!
> Please find the attached v2.patch.
>
> --
> Regards,
> Jones Syue | 薛懷宗
> QNAP Systems, Inc.
>
>
> On Sat, Apr 11, 2020 at 2:25 AM Pavel Shilovsky <piastryyy at gmail.com> wrote:
> >
> > Hi Jones,
> >
> > Thanks for the patch!
> >
> > It will work although it is probably a little bit cleaner to
> > initialize server->max_read to server->maxBuf for SMB1 and use the
> > server->max_read in the readpages condition check instead.
> >
> > @Others, thoughts?
> >
> > --
> > Best regards,
> > Pavel Shilovsky



More information about the samba-technical mailing list