tldap search paged
jra at samba.org
Thu Apr 9 17:44:53 UTC 2020
On Thu, Apr 09, 2020 at 10:28:45AM -0700, Christof Schmitt via samba-technical wrote:
> Since the proposed merge request is only one piece, it probably does not
> make much sense to just merge this individually. Gitlab has the
> convention of tagging "work in progress" as WIP. What about the idea of
> marking the merge request as "WIP", and you continue working on the MR.
> If more patches are ready for review, you can update the WIP merge
> request, ask for feedback and then adjust. Once individual patches look
> good, they can be tagged with "Reviewed-by". When the rework is complete
> and we see the proposed API changes, the API usage and ideally test
> coverage, we can do a final review and merge. Does that sound like a
> possible way forward?
+1 on this. It's not possible to understand
what the purpose is of the proposed MR without
the seeing the context of the calling code.
More information about the samba-technical