selftest/flapping: mark samba3.nbt.dgram.netlogon.* as flapping

Noel Power nopower at suse.com
Sat Apr 4 12:35:15 UTC 2020


Hi Andrew

On 04/04/2020 03:50, Andrew Bartlett wrote:
[...]
> diff --git a/selftest/flapping.d/nbt_dgram
> b/selftest/flapping.d/nbt_dgram
>> new file mode 100644
>> index 00000000000..b4e4c3b4ac8
>> --- /dev/null
>> +++ b/selftest/flapping.d/nbt_dgram
>> @@ -0,0 +1,7 @@
>> +# following SMB1/SMB2 test env split it seems this test
>> +# fails randomly however it doesn't seem to be directly
>> +# related to the changes (e.g. not protocl negotiation
>> +# specific) Best guess is the order of test having being
>> +# changed (as a result of test moving env) or some other
>> +# strange env related side affect is causing this.
>> +^samba3.nbt.dgram.netlogon.*\(ad_dc\)
> This has been flapping for years, and nobody has worked out why.

interesting, I didn't know that, must say don't recall this one in CI
but post these changes this test started flapping more frequently on
gitlab CI on the merge branch. But it took 3 attempts I think to get
this patchset through on autobuild (all failing on this test) strangely
it seems it on the samba-ad-dc-1-mitkrb5 job that it fails in (can't
recall seeing it fail on the normal samba-ad-dc either on gitlab or
sn-devel)

Given the increase in frequency of this test failing randomly it seemed
the sane thing to mark it as flapping. Of course any attempt I made to
reproduce this test failed miserably and it passed fine anytime I tried
to run it either with/without mitkrb5 specific config, very
frustrating.  I'll give it another poke during the week

Noel




More information about the samba-technical mailing list