[PATCH] smbinfo dump encryption keys for using wireshark

Pavel Shilovsky pavel.shilovsky at gmail.com
Tue Sep 24 15:18:47 UTC 2019


+ if (keys_info.cipher_type == 1)
+ printf("CCM encryption");
+ else if (keys_info.cipher_type == 2)
+ printf("GCM encryption");
+ else if (keys_info.cipher_type == 0)
+ printf("SMB3.0 CCM encryption");

Do we need to mention SMB3.0 here? It is the same CCM as cipher_type
1, why don't just extend the 1st IF to

if (keys_info.cipher_type == 0 || keys_info.cipher_type == 1)

+ else
+ printf("unknown encryption type");

Best regards,
Pavel Shilovskiy

пн, 23 сент. 2019 г. в 21:51, Steve French via samba-technical
<samba-technical at lists.samba.org>:
>
> Updated with feedback from Aurelien and Pavel
>
>
>
> --
> Thanks,
>
> Steve



More information about the samba-technical mailing list