Document GitLab as the only way to contribute to Samba?
jra at samba.org
Wed Sep 11 03:17:28 UTC 2019
On Wed, Sep 11, 2019 at 11:34:18AM +1000, Martin Schwenke via samba-technical wrote:
> On Fri, 06 Sep 2019 16:54:17 +1200, Andrew Bartlett via samba-technical
> > I would document it as (roughly):
> > - GitLab is the strongly perferred method to contribute to Samba.
> > - Patches mailed to the mailing list may still be considered, but
> > require additional work on the part of Samba Team members so are
> > discouraged.
> > If you are interested in reviewing patches submitted to Samba, please
> > ensure you have a gitlab.com account and are watching our public gitlab
> > repository.
> Sorry, but NACK.
> Samba is a Free Software project. While that is true we must not
> mandate a proprietary platform as the only way of contributing. Nor
> should we discourage contributions that are not made via a proprietary
> There are many reasons why a new contributor may be unable to use
> GitLab, including:
> * They may not agree with the terms of service
> * They may not wish to take the time to setup an account and be added
> to the required project
> * They may find the user interface unusable
> * They may not have (reliable) web access
> They may still be able to make very worthwhile contributions.
> Ironically, Git - and, therefore, GitLab - exists because the founder of
> the Samba project did not think it reasonable for a proprietary product
> to be mandated for development on another project.
> More pragmatically, GitLab may go away, so we should keep our options
> not only open but also active.
> We should continue to encourage this mailing list as an option for
> contributing to Samba. If a reviewer prefers seeing a GitLab CI
> pipeline pass before they look at code then, if a mailing list
> contribution sounds interesting, they can save the patch, run "git am"
> and push the resulting branch to GitLab GI in less than a minute or 2.
> They can then reply to the contributor saying "looks interesting,
> waiting for GitLab CI pipeline <url> to complete". This mailing list
> isn't so busy that hand-processing a few contributions will swamp any
> reviewer's time.
> Sorry, mate! This is a hill I'm willing to die on...
So if you feel so strongly about this (and I'm sympathetic
to the web UI being just "someone else's computer" issues :-),
is it the wording of:
"Patches mailed to the mailing list may still be considered, but
require additional work on the part of Samba Team members so are
you really object to ? The mailing list isn't going anywhere,
as it's the primary technical discussion list.
How about we re-word this such that we encourage contributors
to use gitlab if they prefer or are used to this interface (as
many new developers are), but still encourage patches on
any medium - including the mailing list ?
We're not so developer-rich that we can afford to turn away
help given by any means :-).
I think the "require(s) additional work on the part of Samba
Team members so is discouraged." is a statement of fact on
Andrew's behalf. It may not be the case for all Team developers
Can you suggest alternative wording that would work for you ?
We do want people who are used to gitlab to feel comfortable
using it to contribute, semi-proprietary though it is:
But we obviously still want to encourage pure Free Software methods
Would that work for you Martin ?
More information about the samba-technical