Insights for the future of smbcmp

[P Mairo]

On Mon Sep 9, 2019 at 11:33 AM Aurélien Aptel wrote:
> "P Mairo via samba-technical" <samba-technical at lists.samba.org> writes:
> > Can you provide me the file(s) you used ? And the steps to reproduce the
> > bug because it just re-tested it and it works just fine
> 
> It happens with all the captures I have. I coudn't find a capture where
> it loops correctly. I'm seaching for "res". It doesn't matter if you
> open the file via the CLI or the menu, happens in both.

I think I get what's going on here, thanks for the feedback

> > - If you select something and then search it won't search starting from
> >>   the selection.
> > I think this is questionable, but you are one of the users so I'll do it
> > accordingly
> 
> This is how most (all?) searches work. Text editors, web browsers, etc
> all search from current cursor position. It is a pretty conventionnal
> way to implement it I would say.
> 
> Cheers,
> -- 
Can you review my changes ? https://github.com/smbcmp/smbcmp/pull/3
I didn't solve the problem of the faulty loop though, I think the problem is with 
the word "res" and ask for confirmation.