Test script test_net_ads.sh can't fail

Isaac Boukris iboukris at redhat.com
Wed Sep 4 09:31:19 UTC 2019


On Wed, Sep 4, 2019 at 9:46 AM Andrew Bartlett <abartlet at samba.org> wrote:
>
> On Wed, 2019-09-04 at 09:20 +0200, Isaac Boukris via samba-technical
> wrote:
> > Hi,
> >
> > I've submitted wip MR #765 and while working on a test, I realized it
> > doesn't fail when it should, right after the first call to testit(),
> > see:
> > https://gitlab.com/samba-team/samba/merge_requests/765/diffs?commit_id=28f588b18c2f13c217d958914d8cbcc0c4a7368b
> >
> > Any clues on this?
>
> Failures in Samba tests are from the failure: lines not the exit
> status.

Ah, I thought it was the exit status, the real bug was actually solved
when I switched to testit_grep.. all ok now.

Thank you



More information about the samba-technical mailing list