Code Review

Andreas Schneider asn at
Thu Oct 17 10:44:04 UTC 2019


we have 4 pages of Merge Requests on gitlab! There are a lot of MRs which are 
valid but nobody is reviewing them. Every month I try to look at MRs at page 4 
and ping people about fixing MRs and or asking for review.

Yesterday and today I closed several MRs.

a) When code bit rotting in MRs is frustrating especially for new
b) If you want code review, you should see it as your duty to also do code

Thank you Andrew for doing most of the reviews!


Andreas Schneider                      asn at
Samba Team                   
GPG-ID:     8DFF53E18F2ABC8D8F3C92237EE0FC4DCC014E3D

More information about the samba-technical mailing list