MR !854 | sess_crypt_blob() fails to decrypt its own cipher text

[Isaac Boukris]

On Wed, Nov 27, 2019 at 6:07 AM Andrew Bartlett <abartlet at samba.org> wrote:
>
> On Sat, 2019-11-23 at 14:30 +0100, Isaac Boukris via samba-technical
> wrote:
> > On Thu, Nov 21, 2019 at 6:52 PM Isaac Boukris <iboukris at gmail.com>
> > wrote:
> > >
> > > While adding tests for sess_crypt_blob() I noticed it fails when
> > > the
> > > input is not aligned to block size of 8, and it looks like we
> > > always
> > > use it this way (see also comment above sess_encrypt_string()), see
> > > pipeline:
> > > https://gitlab.com/samba-team/devel/samba/commits/iboukris-dtest
> >
> > I now realize this branch doesn't prove much, since callers don't
> > check the return value yet, but i also tested with abort().
>
> I've checked the callers in the server, and I'm pretty confident this
> size requirement (being a multiple of 8) is an axiom you can trust.

Thanks for looking at it, that helps.