MR !854 | sess_crypt_blob() fails to decrypt its own cipher text

Andrew Bartlett abartlet at samba.org
Wed Nov 27 05:07:01 UTC 2019


On Sat, 2019-11-23 at 14:30 +0100, Isaac Boukris via samba-technical
wrote:
> On Thu, Nov 21, 2019 at 6:52 PM Isaac Boukris <iboukris at gmail.com>
> wrote:
> > 
> > While adding tests for sess_crypt_blob() I noticed it fails when
> > the
> > input is not aligned to block size of 8, and it looks like we
> > always
> > use it this way (see also comment above sess_encrypt_string()), see
> > pipeline:
> > https://gitlab.com/samba-team/devel/samba/commits/iboukris-dtest
> 
> I now realize this branch doesn't prove much, since callers don't
> check the return value yet, but i also tested with abort().

I've checked the callers in the server, and I'm pretty confident this
size requirement (being a multiple of 8) is an axiom you can trust.

Andrew Bartlett

-- 
Andrew Bartlett
https://samba.org/~abartlet/
Authentication Developer, Samba Team         https://samba.org
Samba Development and Support, Catalyst IT   
https://catalyst.net.nz/services/samba








More information about the samba-technical mailing list