libpytalloc-util 2.2.0 broke the ABI
asn at samba.org
Fri Nov 22 14:07:44 UTC 2019
On Friday, 22 November 2019 10:13:12 CET Andrew Bartlett wrote:
> On Thu, 2019-11-21 at 14:41 +0100, Andreas Schneider via samba-
> technical wrote:
> > This has been introduced by commit
> > 24127acae0f05f0011c4008e75f1a1de31584199
> > ABI: Remove unused .py3*.sigs files
> > These are no longer used by the build system so avoid
> > confusion by removing them from the tree.
> > I'm investigating how we are fixing this in RHEL now. Maybe we have to add
> > the symbols back in our package.
> Ouch. What I will say is this: The py3.sigs stuff was a disaster,
> Debian tried to make it better (but seemed to make it worse, as far as
> I could tell, even minor upgrades failed the debian ABI checker), so I
> dropped both the additional patch and then disabled py3 libs from
> Debian has of course had py3 re-enabled now, but my disable of the py3
> build caused Debian not to be able to ship Python3 bindings for ages.
> The Fedora packages had dramas with how much of the python ABI to
> And then this. I'm kind of glad we accidentally dropped the whole .py3
> ABI file, even if we have to clean up this mess. It has single-
> handedly caused much confusion, work and frustration in packaging
We have to restore the ABI with the .PY3 in the name to deal with it in RHEL
8.2. For RHEL 8.3 we need to fix it correctly upstream. Currently we try to
have a workaround in our package.
> > For Samba I guess we should bump the SO version of libpytalloc-util to 3
> > asap.
> And here re-starts our library versioning discussion. Could we at
> lease merge my 'remove ldb independent version logic', so we can bump
> the pyldb-util ABI without a whole ldb version bump?
Yes, I will discuss it with Alexander again. We need to use a different SO
version for each library.
> > In addition I think we need a CI job which runs the abi-compliance-checker
> > for all public libraries.
> > Fedora provides packages for abi-dumper and abi-compliance-checker. So we
> > could keep an ABI dump from the current released version in the source
> > tree
> > and compare against that one if we break anything.
> Yeah, I guess that's a useful idea. Perhaps extend one of the CI jobs?
> (Please don't create a whole new one if possible).
For a start, 'others' would be the right place, where libt* and libldb is
Maybe we can add it to autobuild.py.
Andreas Schneider asn at samba.org
Samba Team www.samba.org
More information about the samba-technical