[PATCH]: winbind handling NULL sids (bug #13914)

[Amit Kumar]

Hey slow/metze,

https://gitlab.com/samba-team/samba/merge_requests/515

Pipeline again failed.. cannot understand why!! can you try understand why?


On 05/31/2019 02:22 PM, Amit Kumar wrote:
>
> On 05/28/2019 07:19 PM, Stefan Metzmacher wrote:
>> Am 28.05.19 um 11:56 schrieb Ralph Boehme via samba-technical:
>>> On Tue, May 28, 2019 at 12:47:05PM +0530, Amit Kumar wrote:
>>>> Created merge request:
>>>> https://gitlab.com/amitkuma/samba/commit/1a6f331445364de623d02425c8d8b46a59eb2c53
>>>>
>>> Thanks! Unfortunately you targetted the wrong repo
>>> (samba-team/devel/samba instead of samba-team/samba).
>>>
>>> Please follow the instructions at
>>> <https://wiki.samba.org/index.php/Samba_CI_on_gitlab#Other_Samba_developers>
>>>
>>>
>>>> Attached patch as well.
>>>> (0001-s3-winbind-Not-abort-when-received-NULL-SID.patch)
>>> you're somehow munging the patches, replacing tabs for spaces, that's
>>> why the patch again doesn't apply.
> I will be adding spaces not tabs now!!
>
> But don't know why these 2(samba-ad-dc-2, samba-ad-dc-5) stages failed..
> Looked into .shared_template it runs autobuild.py
>>> Looking at the patch, I wonder whether we should skip the trusts with
>>> null-sid instead of adding them?
>> I'd also prefer to skip the domain completely.
> I believe bringing domain check before if() else() would skip the
> complete domain!
>
> +                       if (dom_list_ex.domains[i].sid == NULL) {
> +                                        DEBUG(0, ("Trusted Domain %s
> has no SID, Skipping!\n", trust->dns_name));
> +                                        continue;
> +                       }
>                         if (has_ex) {
>                                 trust->netbios_name = talloc_move(array,
>                                                                  
> &dom_list_ex.domains[i].netbios_name.string);
>                                 trust->dns_name = talloc_move(array,
>                                                              
> &dom_list_ex.domains[i].domain_name.string);
> -                                if (dom_list_ex.domains[i].sid == NULL) {
> -                                        DEBUG(0, ("Trusted Domain %s
> has no SID, aborting!\n", trust->dns_name));
> -                                        return
> NT_STATUS_INVALID_NETWORK_RESPONSE;
> -                                }
>                                 sid_copy(sid, dom_list_ex.domains[i].sid);
>                         } else {
>                                 trust->netbios_name = talloc_move(array,
>                                                                  
> &dom_list.domains[i].name.string);
>                                 trust->dns_name = NULL;
>
>  -                               if (dom_list.domains[i].sid == NULL) {
>  -                                       DEBUG(0, ("Trusted Domain %s
> has no SID, aborting!\n", trust->netbios_name));
>  -                                       return
> NT_STATUS_INVALID_NETWORK_RESPONSE;
>  -                               }
>
>                                 sid_copy(sid, dom_list.domains[i].sid);
>                         }
>
>> metze
>>
>>
>