[PATCH] pac-glue: fix delegation info blob

Isaac Boukris iboukris at gmail.com
Wed May 29 22:31:50 UTC 2019


On Thu, May 30, 2019 at 12:12 AM Andrew Bartlett <abartlet at samba.org> wrote:
>
> On Thu, 2019-05-30 at 00:07 +0200, Isaac Boukris via samba-technical
> wrote:
> > On Wed, May 29, 2019 at 10:04 PM Andreas Schneider <asn at samba.org> wrote:
> > >
> > > On Wednesday, 29 May 2019 18:47:56 CEST Isaac Boukris via samba-technical
> > > wrote:
> > > > On Wed, May 29, 2019 at 6:03 PM Isaac Boukris <iboukris at gmail.com> wrote:
> > > > > Hi,
> > > > >
> > > > > Attached patch fixes the delegation-info blob to be the same as
> > > > > Windows KDC returns, by adding the realm to the correct principal.
> > > >
> > > > Metze points out that this bug is already logged as:
> > > > https://bugzilla.samba.org/show_bug.cgi?id=13133
> > > >
> > > > And thank you for all the other hints!
> > >
> > > Could you add the bug to the patch comment?
> > >
> > > BUG: https://bugzilla.samba.org/show_bug.cgi?id=13133
> >
> > I didn't mention, but the bug has already attached the same patch
> > essentially (without my terminology changes, but in second thought
> > those probably belong in a separate commit).
>
> Yes, but Andreas is asking for the opposite, that is our practice of
> adding BUG: ... to the commit message of every commit fixing or related
> to a bug, so we can track in the git tree which commits fix which bugs.

Sorry for being unclear, what I meant to say is that we can discard my
patch since Metze has already made a patch, attached to this bug (with
the bug number properly specified in the commit message).

Isaac



More information about the samba-technical mailing list