If we are going to exit from smbd, we probably should issue a DBG_ERR not a DBG_WARNING

Richard Sharpe realrichardsharpe at gmail.com
Thu May 16 19:10:43 UTC 2019


Hi folks,

Came across an issue where smbd was silently exiting. Here is a patch:

diff --git a/source3/smbd/server.c b/source3/smbd/server.c
index 3ef7bef..3ac9be9 100644
--- a/source3/smbd/server.c
+++ b/source3/smbd/server.c
@@ -2101,7 +2101,7 @@ extern void build_options(bool screen);
        if (lp_clustering() && !lp_allow_unsafe_cluster_upgrade()) {
                status = smbd_claim_version(msg_ctx, samba_version_string());
                if (!NT_STATUS_IS_OK(status)) {
-                       DBG_WARNING("Could not claim version: %s\n",
+                       DBG_ERR("Could not claim version: %s\n",
                                    nt_errstr(status));
                        return -1;
                }

Signed-off-by: Richard Sharpe <realrichardsharpe at gmail.com>

-- 
Regards,
Richard Sharpe
(何以解憂?唯有杜康。--曹操)(传说杜康是酒的发明者)



More information about the samba-technical mailing list