[PATCH] ctdb-tests: Make reloadips tests more reliable (bug #13924)

Martin Schwenke martin at meltin.net
Tue May 14 04:43:52 UTC 2019


On Fri, 10 May 2019 09:19:43 +1000, Martin Schwenke via samba-technical
<samba-technical at lists.samba.org> wrote:

> On Wed, 8 May 2019 11:31:14 +1000, Martin Schwenke via samba-technical
> <samba-technical at lists.samba.org> wrote:
> 
> > The "ctdb reloadips" can fail for a few reasons, including
> > colliding with a takeover run already in progress.  This was a
> > simplifying design decision.
> > 
> > The tests try to be careful, but there's a startup edge case where an
> > unexpected takeover run can be triggered, though it has been delayed
> > for a quite a while after startup.  
> 
> Please hold this for a while.  This is still failing because it isn't
> retrying.
> 
> Amitay, this is almost certainly an issue with matching the error
> message, which you queried the other day...

OK, the testcase changes were correct.  There was a bug in a previous
patch that fixed try_command_on_node().

Additional patch included here.

Please review and maybe push...

peace & happiness,
martin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: BZ13924-even-more-again.patch
Type: text/x-patch
Size: 2903 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20190514/acd05e91/BZ13924-even-more-again.bin>


More information about the samba-technical mailing list