[PATCH] provision: use ASCII quotes
philipp.gesang at intra2net.com
Fri Mar 29 09:34:55 UTC 2019
Hi Douglas, Noel,
-<| Quoting Douglas Bagnall <douglas.bagnall at catalyst.net.nz>, on Wednesday, 2019-03-13 11:44:24 PM |>-
> Philipp Gesang via samba-technical wrote:
> >>> - input_file = open(input_file_name, "r")
> >>> + input_file = io.open(input_file_name, "rt", encoding='utf8')
> >> I had that first actually but then I tested all ldif files in the
> >> tree and it turned out that only these two codepoints in a single
> >> file were affected.
> >> io.open() and open() are the same btw. and "t" mode is redundant.
> They are *now*. Last week they weren't! That snippet is from those ancient
> times when we theoretically supported 2.6.
> But anyway, I am OK with editing extended-rights.ldif, because as you say
> it has already been edited and is the only funny one there.
> >> read_and_sub_file() is used in other contexts as well so I
> >> triggered a CI run; let’s see what breaks ;)
> >> https://gitlab.com/samba-team/devel/samba/pipelines/51577845
> it passed!
> I think we want that, because these files are data and we don't want to leave their
> interpretation up to environment variables.
> >>> If it does, I would prefer that.
can I ping you on this? I was about to pull the latest source
into our build but can’t see either version of the patch on
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 833 bytes
Desc: not available
More information about the samba-technical