[PATCH] LDAP empty attributes bug

Aaron Haslett aaronhaslett at catalyst.net.nz
Thu Mar 28 23:21:31 UTC 2019

An LDB request interprets an empty attribute list as a request for no
attributes, but LDAP interprets an empty list as a request for all
attributes, and ["1.1"] as a request for no attributes, as per
RFC4511:  Right now we're not doing
the conversion and a lot of code is assuming the incorrect semantics, ie
running a search with attrs=[] and expecting all attributes to be
returned.  Eventually we need to change the semantics by applying the
test attached to the bug on bugzilla, but that will need to be done very
carefully with lots of testing.  This patch adds a test to expose the
bug and fixes the incorrect attrs list usage found by CI testing.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13852

CI: https://gitlab.com/catalyst-samba/samba/pipelines/53975893

-------------- next part --------------
A non-text attachment was scrubbed...
Name: ldap_empty_attributes.patch
Type: text/x-patch
Size: 6597 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20190329/32a96606/ldap_empty_attributes.bin>

More information about the samba-technical mailing list