[RFC PATCH] CephFS Snapshots VFS module

Jeremy Allison jra at samba.org
Thu Mar 28 21:10:34 UTC 2019


On Wed, Mar 27, 2019 at 04:39:30PM +0100, David Disseldorp via samba-technical wrote:
> The attached patchset adds a new vfs_ceph_snapshots VFS module which
> handles snapshot enumeration and timewarp/@GMT token mapping.
> 
> I've tagged it as an RFC for now, as it depends on a new CephFS virtual
> xattr to obtain the snapshot creation time, which is pending merge:
> https://tracker.ceph.com/issues/38838
> 
> Feedback appreciated.

Thanks !

> From 9f47b9732883b56c64ed5f9b8705682b4b0cb735 Mon Sep 17 00:00:00 2001
> From: David Disseldorp <ddiss at samba.org>
> Date: Wed, 27 Mar 2019 13:10:04 +0100
> Subject: [PATCH 1/4] vfs_ceph: drop fdopendir handler
> 
> libcephfs doesn't currently offer an fdopendir equivalent, so the
> existing implementation peeks at fsp->fsp_name->base_name, which can
> break if vfs_ceph is used under a separate path-munging VFS module.
> 
> Return ENOSYS instead and rely on existing OpenDir_fsp() fallback.

Any chance libcephfs will be implementing fdopendir()
sometime ?

It's a really important call for removing pathname
race conditions from Samba.



More information about the samba-technical mailing list