[PATCH] samba-tool: fix some typos

Björn Baumbach bb at sernet.de
Thu Mar 28 16:37:34 UTC 2019


Hi!

In the samba-tool all command descriptions have a dot '.' at the end.
The ou and visualize command need this too.

# samba-tool
 ...
 group       - Group management.
 ldapcmp     - Compare two ldap databases.
 ntacl       - NT ACLs manipulation.
 ou          - Organizational Units (OU) management
 ...
 user        - User management.
 visualize   - Produces graphical representations of Samba network state

Need a review for the attached patch.

Best regards,
Björn

-- 
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: 0551-370000-0, mailto:kontakt at sernet.de
Gesch.F.: Dr. Johannes Loxen und Reinhild Jung
AG Göttingen: HR-B 2816 - http://www.sernet.de
-------------- next part --------------
From 9fb7e8c84ab35b01ddc47f17032ae56c5d0bcfc2 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bj=C3=B6rn=20Baumbach?= <bb at sernet.de>
Date: Thu, 28 Mar 2019 17:24:40 +0100
Subject: [PATCH] samba-tool: fix some typos
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

All command descriptions have a dot '.' at the end.
The ou and visualize command need this too.

  ...
  group       - Group management.
  ldapcmp     - Compare two ldap databases.
  ntacl       - NT ACLs manipulation.
  ou          - Organizational Units (OU) management
  ...
  user        - User management.
  visualize   - Produces graphical representations of Samba network state

Signed-off-by: Björn Baumbach <bb at samba.org>
---
 python/samba/netcmd/ou.py        | 6 +++---
 python/samba/netcmd/visualize.py | 2 +-
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/python/samba/netcmd/ou.py b/python/samba/netcmd/ou.py
index ecc4582cbcf..a715a5bee13 100644
--- a/python/samba/netcmd/ou.py
+++ b/python/samba/netcmd/ou.py
@@ -1,6 +1,6 @@
-# implement samba_tool ou commands
+# implement samba-tool ou commands
 #
-# Copyright Bjoern Baumbach <bb at sernet.de> 2018
+# Copyright Bjoern Baumbach 2018-2019 <bb at samba.org>
 #
 # This program is free software; you can redistribute it and/or modify
 # it under the terms of the GNU General Public License as published by
@@ -390,7 +390,7 @@ class cmd_delete(Command):
 
 
 class cmd_ou(SuperCommand):
-    """Organizational Units (OU) management"""
+    """Organizational Units (OU) management."""
 
     subcommands = {}
     subcommands["create"] = cmd_create()
diff --git a/python/samba/netcmd/visualize.py b/python/samba/netcmd/visualize.py
index a0eb676eb31..3b99c6c6e02 100644
--- a/python/samba/netcmd/visualize.py
+++ b/python/samba/netcmd/visualize.py
@@ -705,7 +705,7 @@ class cmd_uptodateness(GraphCommand):
 
 
 class cmd_visualize(SuperCommand):
-    """Produces graphical representations of Samba network state"""
+    """Produces graphical representations of Samba network state."""
     subcommands = {}
 
     for k, v in globals().items():
-- 
2.19.2



More information about the samba-technical mailing list