[PATCH] tevent-glib-glue

Andrew Bartlett abartlet at samba.org
Fri Mar 22 19:18:20 UTC 2019


On Fri, 2019-03-22 at 16:21 +0100, Ralph Böhme via samba-technical
wrote:
> 
> Also, tevent_glib_glue is now only dependent on glib2-devel, not 
> --enable-spotlight. Hopefully we can get glib2-devel in the gitlab
> image, I've 
> requested this via the mailing list.

Thanks for doing that.  

I think that once this is done you should make it mandatory for --
enable-selftest (ideally in waf, at least have the test fail).  

After some bad experiences I've come to the view that our selftest
should not alter itself based on the build environment, it is too easy
to have tests mysteriously disappear.

(For the impossible cases we could pass in skip files).

Thanks!

Andrew Bartlett

-- 
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba






More information about the samba-technical mailing list