[PATCH] Some fixes for buildtools, flapping tests and libxcrypt support

[Andreas Schneider]

On Thursday, March 21, 2019 9:46:16 AM CET Samuel Cabrero via samba-technical 
wrote:
> Hi,

Hi Samuel,

> please consider the following patches that fix several problems found
> while debugging failed tests in latest openSUSE Tumbleweed:
> 
> * Fix "makedev()" detection in glibc >= 2.25

I've debugged the same issue with Ralph today. Your fix will not work on 
FreeBSD, as it doesn't have sys/sysmacros.h. I've created a merge request with 
additional fixes I did while debugging here:

https://gitlab.com/samba-team/samba/merge_requests/319

> * Fix flapping samba3.blackbox.shadow_copy_torture

Please use ZERO_STRUCT(tm);

> * Workaround uid wrapper issues when using bash shell

LGTM

> * Fix password_hash LDB module when crypt(_r) is provided by libxcrypt

Please use `errno != 0`

> * Fix password_hash_fl2008 test when using libxcrypt, it requires a
> minumum of 1000 rounds for CryptSHA256

LGTM

> Gitlab pipeline:
> https://gitlab.com/scabrero/samba/pipelines/52798218
> 
> Gitlab branch:
> https://gitlab.com/scabrero/samba/commits/master-opensuse-ci

Samuel, I've added you to

https://gitlab.com/samba-team/devel/samba/

so you're able to push your branch there to get a full CI run, please create a 
merge request from there.

See https://wiki.samba.org/index.php/Samba_CI_on_gitlab


Great work!


Cheers,


	Andreas

-- 
Andreas Schneider                      asn at samba.org
Samba Team                             www.samba.org
GPG-ID:     8DFF53E18F2ABC8D8F3C92237EE0FC4DCC014E3D