Adding a new VFS Lttng module for performance testing
deanraccoon
deanraccoon at gmail.com
Thu Mar 21 06:31:23 UTC 2019
hi, Ralph,
thank you for your review, But I do not have time to update this
patch. So can you help?
> 've added a call to smb_vfs_assert_all_fns() to the init function of the
> module. That asserts that the module implements all VFS functions. Currently
> quite a bunch are missing, eg pread_send but also stuff that has been added
> recently, like get_dos_attributes_send_fn or vfswrap_getxattrat_send.
> Can you add the missing functions or do you want us to do that?
Ralph Böhme <slow at samba.org> 于2019年3月19日周二 上午6:15写道:
>
> On Tue, Jan 15, 2019 at 08:11:36AM +0100, Ralph Böhme wrote:
> >On Tue, Jan 15, 2019 at 02:45:18PM +0800, deanraccoon wrote:
> >>ping Ralph?
> >
> >Sorry! I have it on my list and will try to get to it over the next days.
>
> took a little longer, but here we go! Sorry! :)
>
> I've took the liberty to do some reformatting and cleanup so the code better
> matches the Samba coding style, much of which is summarized in README.Coding.
>
> I've added a call to smb_vfs_assert_all_fns() to the init function of the
> module. That asserts that the module implements all VFS functions. Currently
> quite a bunch are missing, eg pread_send but also stuff that has been added
> recently, like get_dos_attributes_send_fn or vfswrap_getxattrat_send.
>
> Can you add the missing functions or do you want us to do that?
>
> -slow
>
> --
> Ralph Boehme, Samba Team https://samba.org/
> Samba Developer, SerNet GmbH https://sernet.de/en/samba/
> GPG-Fingerprint FAE2C6088A24252051C559E4AA1E9B7126399E46
--
张冬卯 此致
More information about the samba-technical
mailing list