[PATCH] tevent-glib-glue

Noel Power nopower at suse.com
Wed Mar 20 10:14:12 UTC 2019

On 18/03/2019 10:55, Ralph Böhme wrote:
> Hi Noel,
> sorry for the delay, had two days off.

No problem, I am just back today from even more days than that off :->>>

I see below (snipped) you have a new patch set, I'll get to it asap,
just beware the usual post days off mail mountain will interfere a bit :-)

> On Thu, Mar 14, 2019 at 05:15:07PM +0000, Noel Power wrote:
>> The problem I see is that if this glib tracker api results in any
>> changes to the set of glib fd(s) or timeouts that need to be monitored
>> then the glue code may not be aware of these changes (because the
>> prepare phase is only called from glib glue tevent handlers) See
>> attached async_tracker.c patch which attempts to fake these scenarios. [1]
> ah, finally got it. :)
> This should be addressed in the attached patchset. I'm basically taking you tevent tracepoint approach with some simplifications.
> I've also added tests to the testsuite that cover both cases: adding a new glib event source from a glib event handler as well as adding one from a tevent event handler.
> Updated patchset attached.
> CI: https://gitlab.com/samba-team/devel/samba/pipelines/52336817
> -slow
cool, will start to get into this hopefully end of today, thanks alot


More information about the samba-technical mailing list