[PATCH] DON'T PANIC!

[Ralph Böhme]

On Mon, Mar 18, 2019 at 06:50:36PM +0100, David Disseldorp wrote:
>On Mon, 18 Mar 2019 17:12:32 +0100, Ralph Böhme via samba-technical wrote:
>
>> A customer ran into this when the FUSE mount he was sharing with Samba went
>> dead.
>>
>> An abort makes it look like a problem in Samba, so instead of aborting we may
>> want to simply exit in this error case (and probably a few others).
>
>I don't think exiting with success (0) is the right thing to do if the
>underlying FS is borked. If you really want to avoid panic, would
>exit_server() be an option, or are you deliberately trying to avoid the
>unclean_shutdown path for a reason?

yes. In the common exit function we have this:

        if (how != SERVER_EXIT_NORMAL) {
                smb_panic(reason);
        ...

If you look at the existing callers of exit_server_cleanly() you'll find that 
it's called in a lot of places where we equally doomed. :)

-slow

-- 
Ralph Boehme, Samba Team                https://samba.org/
Samba Developer, SerNet GmbH   https://sernet.de/en/samba/
GPG-Fingerprint   FAE2C6088A24252051C559E4AA1E9B7126399E46