Ralph Böhme slow at samba.org
Mon Mar 18 16:12:32 UTC 2019


A customer ran into this when the FUSE mount he was sharing with Samba went 

An abort makes it look like a problem in Samba, so instead of aborting we may 
want to simply exit in this error case (and probably a few others).

Please review&push if happy. Thanks!


Ralph Boehme, Samba Team                https://samba.org/
Samba Developer, SerNet GmbH   https://sernet.de/en/samba/
GPG-Fingerprint   FAE2C6088A24252051C559E4AA1E9B7126399E46
-------------- next part --------------
From 70568ae04e5b5bd9e358a9f2105ddd72a19ca522 Mon Sep 17 00:00:00 2001
From: Ralph Boehme <slow at samba.org>
Date: Thu, 31 Jan 2019 10:46:24 +0100
Subject: [PATCH] s3:smbd: don't panic in process_symlink_open() error code

This was hit on a system with a FUSE filesystem that went dead.

DON'T PANIC! A simple exit_server_cleanly() should be enough. A crashing
Samba makes it look like there's a real problem in Samba where this is
clearly not the case here.

Signed-off-by: Ralph Boehme <slow at samba.org>
 source3/smbd/open.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/source3/smbd/open.c b/source3/smbd/open.c
index bab9286751f..90ee664796c 100644
--- a/source3/smbd/open.c
+++ b/source3/smbd/open.c
@@ -563,7 +563,7 @@ static int process_symlink_open(struct connection_struct *conn,
 	if (oldwd_fname != NULL) {
 		int ret = vfs_ChDir(conn, oldwd_fname);
 		if (ret == -1) {
-			smb_panic("unable to get back to old directory\n");
+			exit_server_cleanly("unable to chdir to old directory");

More information about the samba-technical mailing list