[PATCH] ctdb/tests: add missing dependency to libreplace for PTHREAD_MUTEX_ROBUST
bb at sernet.de
Tue Mar 12 10:42:38 UTC 2019
On 2/8/19 4:28 AM, Amitay Isaacs wrote:
> On Thu, Feb 7, 2019 at 10:16 PM Stefan Metzmacher via samba-technical
> <samba-technical at lists.samba.org> wrote:
>>> The attached path solves a build issue in the ctdb tests:
>>> [2694/3871] Compiling ctdb/tests/src/test_mutex_raw.c
>>> ../ctdb/tests/src/test_mutex_raw.c: In function ‘main’:
>>> ../ctdb/tests/src/test_mutex_raw.c:332: error: ‘PTHREAD_MUTEX_ROBUST’
>>> undeclared (first use in this function)
>>> Please review :-)
>> I think we want deps='replace pthread'.
>> Otherwise it looks good.
> NACK. This test is in ctdb directory just to keep track of it. It
> has nothing to do with samba or ctdb.
> It's better to keep this test standalone and not pollute with build
> dependencies on samba tree.
> Björn, what platform is the build failing on?
Thank you for having a look on this.
I've seen that on an old sles11 with glibc-2.9.
On modern systems I do not have any issues with this.
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: 0551-370000-0, mailto:kontakt at sernet.de
Gesch.F.: Dr. Johannes Loxen und Reinhild Jung
AG Göttingen: HR-B 2816 - http://www.sernet.de
Samba eXPerience 2019, Hotel Freizeit In
sponsored by Google, Microsoft & Red Hat
June, 4th - 6th 2019, http://sambaXP.org
More information about the samba-technical