[PATCH] passdb: Increase ABI version to 0.28.0

[Andreas Schneider]

On Thursday, March 7, 2019 9:49:13 AM CET Lukas Slebodnik via samba-technical 
wrote:
> On (06/03/19 15:12), Jeremy Allison wrote:
> >On Wed, Mar 06, 2019 at 03:01:19PM -0700, Christof Schmitt via samba-
technical wrote:
> >> Past changes of this library versions have been done by incrementing the
> >> second number as "major" and the third as "minor". My guess is that the
> >> leading 0 tries to state that this is not necessarily a stable API.
> >> 
> >> You are correct that this does not conform to the normal handling of
> >> library versions. The question is whether we stick to the old scheme for
> >> now and discuss library versioning separately; or whether passdb should
> >> become 1.0.0 now. I would like to hear other opinions on this topic.
> >
> >Oh, when you put it like *that* :-). passdb should certainly
> >*not* be at 1.0.0 :-).
> >
> >OK, fair enough. Let's leave it at 0.28.0 for master.
> 
> Could you explain why ?
> 
> You have to bump SONAME because of backward incompatible change in public
> library especially for master.
> 
> If you want you can have 1.28.0 and not 1.0.0 that's just tiny detail IMHO

Lukas is right. The SO version is MAJOR.MINOR.PATCH

MAJOR needs be bumped if you have an API incompatible change, e.g. removing a 
functions which was public before.

MINOR needs to be bumped if you add something to the public API, add a value 
to an enum, new function, new define etc.

PATCH is increased if only a code change and the API did not change in any 
way.


So if you remove a function you need to bump the MAJOR so we will get 1.0.0!


	Andreas





-- 
Andreas Schneider                      asn at samba.org
Samba Team                             www.samba.org
GPG-ID:     8DFF53E18F2ABC8D8F3C92237EE0FC4DCC014E3D