[PATCH] Some selftest tidy-ups to centralize IP address logic

Jeremy Allison jra at samba.org
Wed Mar 6 01:17:53 UTC 2019

On Wed, Mar 06, 2019 at 02:14:46PM +1300, Andrew Bartlett via samba-technical wrote:
> On Wed, 2019-03-06 at 12:09 +1300, Tim Beale via samba-technical wrote:
> > This tries to tidy up and centralize the assumptions that selftest makes
> > on what IP addresses the testenvs have. It also moves the
> > IP-to-DNS-realm mapping out of dns_hub and into Samba.pm, so it's all in
> > one place. Hopefully this will make it easier to keep the testenv realms
> > and IPs in sync longer-term.
> > 
> > CI pass: https://gitlab.com/catalyst-samba/samba/pipelines/50458108
> > 
> > Review appreciated. Thanks.
> Nice work!
> It is really great to have this information (the IP/realm/environment
> mappings) centralised again.

Yeah, I must confess I was planning to push that also (but I'm
glad you got to it first, as my python isn't as good :-), looks
a really nice cleanup !

More information about the samba-technical mailing list