[PATCH] passdb: Increase ABI version to 0.28.0

[Alexander Bokovoy]

On ti, 05 maalis 2019, Jeremy Allison wrote:
> On Tue, Mar 05, 2019 at 05:21:36PM +0200, Alexander Bokovoy via samba-technical wrote:
> > On ti, 05 maalis 2019, Volker Lendecke via samba-technical wrote:
> > > On Tue, Mar 05, 2019 at 04:48:22PM +0200, Alexander Bokovoy wrote:
> > > > FreeIPA implements a PASSDB module which is loaded into Samba. It needs
> > > > to get access to the same API other PASSDB modules have to use.
> > > 
> > > Ok, thanks. I've closed the bug as WONTFIX, so none of this is of interest anymore.
> > Could you please explain, why?
> > 
> > The reason I ask is that https://bugzilla.samba.org/show_bug.cgi?id=13813 is about 
> > backporting changes from git master. Whether you backport them or not,
> > the symbols were removed already in master, so in my case ipasam needs
> > to be adopted to that anyway.
> > 
> > I find the changes from https://bugzilla.samba.org/show_bug.cgi?id=13813
> > helpful. Would it help if we make FreeIPA working with git master and
> > then backport those patches without actual removal of the ABI symbols?
> > Then both Samba 4.8-4.10 and FreeIPA in the releases where Samba
> > 4.8-4.10 is used can be updated without breakage. Samba 4.11 would
> > introduce the ABI break but the code out there will be ready to it by
> > the time.
> > 
> > If I'm correct, the only part of the backports that needs to be withhold
> > is the commit c906153cc7af21abe508ddd30c447642327d6a5d.
> 
> Trying to direct the conversation back onto more useful lines.. :-).
> 
> Commit c906153cc7af21abe508ddd30c447642327d6a5d is the
> removal of winbind_uid_to_sid() and winbind_gid_to_sid()
> 
> -bool winbind_uid_to_sid(struct dom_sid *sid, uid_t uid);
> -bool winbind_gid_to_sid(struct dom_sid *sid, gid_t gid);
> 
> There are calling the wbcUidToSid() and wbcGidToSid()
> functions internally, which can still be called by wbinfo.
> 
> How is FreeIPA using these ?
FreeIPA doesn't use those. 
It uses the translation routines removed (below).



> 
> It also removes:
> 
> -/* The following definitions come from passdb/pdb_unixid.c */
> -void unixid_from_uid(struct unixid *id, uint32_t some_uid);
> -void unixid_from_gid(struct unixid *id, uint32_t some_gid);
> -void unixid_from_both(struct unixid *id, uint32_t some_id);
> 
> Which are only translating into a structure.
Because the structure is opaque, we used the translation routines to
keep us less broken.

> Does keeping that code for the back-ports work ? What
> exactly do you need these for ?
> 
> Looking at the attachments for:
> 
> https://bugzilla.samba.org/show_bug.cgi?id=13813
> 
> Can you re-open bug https://bugzilla.samba.org/show_bug.cgi?id=13813
> and upload a version of the 4.10.x, 4.9.x, 4.8.x back-port patches
> that will work for you and FreeIPA so I can take a look at the
> complete list of things you need for a working backport ?
> 
> Also, c906153cc7af21abe508ddd30c447642327d6a5d isn't
> present in the current attachment for the 4.8.x back-port,
> or in the 4.9.x back-port, but only in the 4.10.x back-port.
> 
> Is that the only back-port you need modifying ?
> 
> I'm still trying to get a good handle on the problem
> here.
I'll look at that in next two days. Sorry, cannot promise more details
as I have day full of meetings tomorrow.

-- 
/ Alexander Bokovoy