[PATCH] passdb: Increase ABI version to 0.28.0

Alexander Bokovoy ab at samba.org
Tue Mar 5 12:04:51 UTC 2019


On ti, 05 maalis 2019, Lukas Slebodnik via samba-technical wrote:
> On (05/03/19 12:14), Lukas Slebodnik via samba-technical wrote:
> >On (04/03/19 14:38), Christof Schmitt via samba-technical wrote:
> >>From 600c19fd31b9a596e4de1e56dd10f25cd1bf8780 Mon Sep 17 00:00:00 2001
> >>From: Christof Schmitt <cs at samba.org>
> >>Date: Mon, 4 Mar 2019 14:13:22 -0700
> >>Subject: [PATCH] passdb: Increase ABI version to 0.28.0
> >>
> >>The change from c906153cc lib: Remove some unused code
> >>removed functions, but only updated the minor version
> >>of the ABI. Update the passdb version to 0.28.0
> >>to reflect this change and also remove the 0.27.2
> >>file.
> >>
> >>BUG: https://bugzilla.samba.org/show_bug.cgi?id=13813
> >>
> >>Signed-off-by: Christof Schmitt <cs at samba.org>
> >>---
> >> .../ABI/{samba-passdb-0.27.2.sigs => samba-passdb-0.28.0.sigs}  | 0
> >> source3/wscript_build                                           | 2 +-
> >> 2 files changed, 1 insertion(+), 1 deletion(-)
> >> rename source3/passdb/ABI/{samba-passdb-0.27.2.sigs => samba-passdb-0.28.0.sigs} (100%)
> >>
> >>diff --git a/source3/passdb/ABI/samba-passdb-0.27.2.sigs b/source3/passdb/ABI/samba-passdb-0.28.0.sigs
> >>similarity index 100%
> >>rename from source3/passdb/ABI/samba-passdb-0.27.2.sigs
> >>rename to source3/passdb/ABI/samba-passdb-0.28.0.sigs
> >>diff --git a/source3/wscript_build b/source3/wscript_build
> >>index 41f01e392e2..ed4de978fdc 100644
> >>--- a/source3/wscript_build
> >>+++ b/source3/wscript_build
> >>@@ -149,7 +149,7 @@ bld.SAMBA3_LIBRARY('samba-passdb',
> >>                                   ''',
> >>                    abi_match=private_pdb_match,
> >>                    abi_directory='passdb/ABI',
> >>-                   vnum='0.27.2')
> >>+                   vnum='0.28.0')
> >> 
> >> bld.SAMBA3_SUBSYSTEM('pdb',
> >>                    source='''
> >
> >Removing functions is always backward incompatible change.
> >It is a public library and you cannot know who were using them.
> >
> >You should bump SONAME (the 1st number). Bumping 2nd number is for backward
> >compatible changes (e.g. adding function)
> >
> 
> Adding ab to CC cause I can see usage of removed functions in freeipa
> 
> sh [~/freeipa]$ git grep unixid_from_uid
> daemons/ipa-sam/ipa_sam.c:      unixid_from_uid(id, strtoul(value, NULL, 10));
> daemons/ipa-sam/ipa_sam.c:      unixid_from_uid(&id, uid);
> sh[~/freeipa]$ git grep unixid_from_gid
> daemons/ipa-sam/ipa_sam.c:              unixid_from_gid(id, strtoul(gid_str,
>                 NULL, 10));
> daemons/ipa-sam/ipa_sam.c:      unixid_from_gid(&id, gid);
> daemons/ipa-sam/ipa_sam.c:      unixid_from_gid(&id, gid);
> daemons/ipa-sam/ipa_sam.c:      unixid_from_gid(&id, gid);
I can deal with that if a header generated from idmap.idl would be
installed publicly. That's the only reason we used these functions --
'struct unixid' definition is not public.

Attached patch allows to make it public.

-- 
/ Alexander Bokovoy
-------------- next part --------------
>From 9a6e1af67ccc4fa92f17fd143f5a24c6c9269df0 Mon Sep 17 00:00:00 2001
From: Alexander Bokovoy <ab at samba.org>
Date: Tue, 5 Mar 2019 13:45:54 +0200
Subject: [PATCH] librpc: make gen_ndr/idmap.h a public header

Since c906153cc helpers to operate on 'struct unixid' were removed but
the 'struct unixid' is not public. Without making it public or helpers
it is not possible to feed idmap cache with proper values.

Since the header is trivial and only has structure definitions, make it public.

Signed-off-by: Alexander Bokovoy <ab at samba.org>
---
 librpc/wscript_build | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/librpc/wscript_build b/librpc/wscript_build
index 8e113c422b2..e3144a69615 100644
--- a/librpc/wscript_build
+++ b/librpc/wscript_build
@@ -224,7 +224,8 @@ bld.SAMBA_SUBSYSTEM('NDR_RAP',
 
 bld.SAMBA_SUBSYSTEM('NDR_IDMAP',
     source='gen_ndr/ndr_idmap.c',
-    public_deps='ndr ndr-standard'
+    public_deps='ndr ndr-standard',
+    public_headers='gen_ndr/idmap.h'
     )
 
 bld.SAMBA_SUBSYSTEM('NDR_NOTIFY',
-- 
2.20.1



More information about the samba-technical mailing list