[PATCH] passdb: Increase ABI version to 0.28.0

[Lukas Slebodnik]

On (05/03/19 12:14), Lukas Slebodnik via samba-technical wrote:
>On (04/03/19 14:38), Christof Schmitt via samba-technical wrote:
>>From 600c19fd31b9a596e4de1e56dd10f25cd1bf8780 Mon Sep 17 00:00:00 2001
>>From: Christof Schmitt <cs at samba.org>
>>Date: Mon, 4 Mar 2019 14:13:22 -0700
>>Subject: [PATCH] passdb: Increase ABI version to 0.28.0
>>
>>The change from c906153cc lib: Remove some unused code
>>removed functions, but only updated the minor version
>>of the ABI. Update the passdb version to 0.28.0
>>to reflect this change and also remove the 0.27.2
>>file.
>>
>>BUG: https://bugzilla.samba.org/show_bug.cgi?id=13813
>>
>>Signed-off-by: Christof Schmitt <cs at samba.org>
>>---
>> .../ABI/{samba-passdb-0.27.2.sigs => samba-passdb-0.28.0.sigs}  | 0
>> source3/wscript_build                                           | 2 +-
>> 2 files changed, 1 insertion(+), 1 deletion(-)
>> rename source3/passdb/ABI/{samba-passdb-0.27.2.sigs => samba-passdb-0.28.0.sigs} (100%)
>>
>>diff --git a/source3/passdb/ABI/samba-passdb-0.27.2.sigs b/source3/passdb/ABI/samba-passdb-0.28.0.sigs
>>similarity index 100%
>>rename from source3/passdb/ABI/samba-passdb-0.27.2.sigs
>>rename to source3/passdb/ABI/samba-passdb-0.28.0.sigs
>>diff --git a/source3/wscript_build b/source3/wscript_build
>>index 41f01e392e2..ed4de978fdc 100644
>>--- a/source3/wscript_build
>>+++ b/source3/wscript_build
>>@@ -149,7 +149,7 @@ bld.SAMBA3_LIBRARY('samba-passdb',
>>                                   ''',
>>                    abi_match=private_pdb_match,
>>                    abi_directory='passdb/ABI',
>>-                   vnum='0.27.2')
>>+                   vnum='0.28.0')
>> 
>> bld.SAMBA3_SUBSYSTEM('pdb',
>>                    source='''
>
>Removing functions is always backward incompatible change.
>It is a public library and you cannot know who were using them.
>
>You should bump SONAME (the 1st number). Bumping 2nd number is for backward
>compatible changes (e.g. adding function)
>

Adding ab to CC cause I can see usage of removed functions in freeipa

sh [~/freeipa]$ git grep unixid_from_uid
daemons/ipa-sam/ipa_sam.c:      unixid_from_uid(id, strtoul(value, NULL, 10));
daemons/ipa-sam/ipa_sam.c:      unixid_from_uid(&id, uid);
sh[~/freeipa]$ git grep unixid_from_gid
daemons/ipa-sam/ipa_sam.c:              unixid_from_gid(id, strtoul(gid_str,
                NULL, 10));
daemons/ipa-sam/ipa_sam.c:      unixid_from_gid(&id, gid);
daemons/ipa-sam/ipa_sam.c:      unixid_from_gid(&id, gid);
daemons/ipa-sam/ipa_sam.c:      unixid_from_gid(&id, gid);

LS