[PATCH] Fix string to integer conversion

Ralph Böhme slow at samba.org
Mon Mar 4 19:55:42 UTC 2019



> Am 01.03.2019 um 01:15 schrieb Jeremy Allison <jra at samba.org>:
> 
> On Thu, Feb 28, 2019 at 12:55:52PM +0100, Ralph Böhme wrote:
>> On Thu, Feb 28, 2019 at 11:30:08AM +0100, swen wrote:
>>> New patchset attached.
>> 
>> Looks good. And I ran
>> 
>> $ git log -p HEAD~20..HEAD | grep "int error"
>> 
>> to verify. :)
>> 
>> So +1 from me on everything but the last one.
>> 
>> Jeremy, can you take a look?
> 
> Dropping patch #17 as that's directly modifying
> 
> third_party/nss_wrapper/
> third_party/socket_wrapper/
> third_party/uid_wrapper/
> 
> which Andreas meantains separately. That needs
> to go upstream first.

sorry, missed that in this review round, I think I mentioned this in a previous one.

-slow


More information about the samba-technical mailing list