Please make GitLab merge requests

Andrew Bartlett abartlet at samba.org
Mon Mar 4 06:54:29 UTC 2019


On Mon, 2019-03-04 at 07:36 +0100, Andreas Schneider via samba-
technical wrote:
> On Monday, 11 February 2019 16:02:32 CET Andreas Schneider via samba-technical 
> wrote:
> > On Thursday, February 7, 2019 9:33:10 AM CET Andreas Schneider via samba-
> > 
> > technical wrote:
> > > Hi,
> > > 
> > > attached is a patch to fix an issue with smbspool as a CUPS backend
> > > configured to use Kerberos.
> > > 
> > > See details at https://bugzilla.redhat.com/show_bug.cgi?id=1662408
> > > 
> > > 
> > > Review much appreciated.
> > 
> > Ping!
> 
> This patch is still looking for a reviewer ...

Can you make a merge request with it?

I know I sound like a broken record, but there is some sense to it:

I personally make review of merge requests a priority and it is a great
public TODO list, with all the CI results, patches and comments well
collected.

We shouldn't rely on you, or anyone else, needing to personally resend
patches to remind us that a patch is outstanding, we have computers for
that.

Thanks!

Andrew Bartlett

-- 
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba





More information about the samba-technical mailing list