question about contributin

David Disseldorp ddiss at
Fri Mar 1 10:55:15 UTC 2019

Hi Kristján,

On Fri, 1 Mar 2019 10:47:10 +0000, Kristján Valur Jónsson via samba-technical wrote:

> Making my second attempt at contributing to samba, this time through
> gitlab-ci.
> One thing that isn"t clear to me, from reading the wiki, is how to proceed
> with a branch consisting of several discrete commits (for clarity).  Do I
> sign off each commit? 

Yes, please make sure each and every commit includes a Signed-off-by
tag. You can do this with "git commit -s".

> How to I request a review and merge of the whole
> branch?

Via you can submit a merge request against the master branch
of the Samba Team repo, with your repo+branch as the source.

Cheers, David

More information about the samba-technical mailing list