Document GitLab as the only way to contribute to Samba?

Rowland penny rpenny at samba.org
Fri Jun 21 07:13:56 UTC 2019


On 21/06/2019 02:58, Andrew Bartlett via samba-technical wrote:
> On Fri, 2019-06-21 at 11:14 +1000, Martin Schwenke via samba-technical
> wrote:
>> On Fri, 21 Jun 2019 13:05:17 +1200, Andrew Bartlett via samba-technical
>> <samba-technical at lists.samba.org> wrote:
>>
>>> I gave a talk at SambaXP about our first year with GitLab, and one
>>> point I made is that it is *not OK* to have public contribution
>>> documentation that does not match our actual practice.
>>> So, I would like to propose this.  That given the practice of the Samba
>>> Team and almost all contributors is to contribute via a merge request
>>> against https://gitlab.com/samba-team/samba that we document this, and
>>> only this, as how to contribute to new patches to Samba.
>>>
>> I don't think it is the practice of the whole Samba Team.  I haven't
>> managed to get into the GitLab workflow, though I have used it.
>>
>> Perhaps I'm the only one, but I don't think we should be mandating this
>> (yet?)...
> G'Day Martin,
>
> Thanks for the feedback.  I should have checked rather than working on
> a 'gut feel' and I see you are still using samba-technical a fair
> bit[1].
>
> I would say that aside from your patches, the vast majority of the
> patch flow has moved to GitLab.
>
> To help us present a clear process, do you think you could embrace
> GitLab, if not for the benefits to you, but for the sake of our new
> contributors?
>
> The alternatives are (to my mind):
>   - Contributors get ignored on samba-technical (both because the
> patches are not known-good and because they are not on a clear to-do
> list)
>   - Contributors other than yourself keep getting told off for doing it
> 'wrong'.
>
> What do you think?
>
> Christof,
>
> You are the other person I still using samba-technical much at all to
> submit patches.  Is there anything I can do to help you make the move
> to GitLab, or is there anything stopping you?
>
> Thanks,
>
> Andrew Bartlett
>
> [1] Attached is the histogram of patches on samba-technical from April
> -> June, for the curious.
>
Sorry, but I do not think it is 'wrong' to not want to use git-lab. 
Perhaps we should 'prefer' people to use git-lab, but we definitely 
shouldn't tell anybody off for sending a patch directly to samba-technical.

Rowland




More information about the samba-technical mailing list