Document GitLab as the only way to contribute to Samba?

Andrew Bartlett abartlet at samba.org
Fri Jun 21 01:58:10 UTC 2019


On Fri, 2019-06-21 at 11:14 +1000, Martin Schwenke via samba-technical
wrote:
> On Fri, 21 Jun 2019 13:05:17 +1200, Andrew Bartlett via samba-technical
> <samba-technical at lists.samba.org> wrote:
> 
> > I gave a talk at SambaXP about our first year with GitLab, and one
> > point I made is that it is *not OK* to have public contribution
> > documentation that does not match our actual practice.

> > So, I would like to propose this.  That given the practice of the Samba
> > Team and almost all contributors is to contribute via a merge request
> > against https://gitlab.com/samba-team/samba that we document this, and
> > only this, as how to contribute to new patches to Samba.
> > 

> I don't think it is the practice of the whole Samba Team.  I haven't
> managed to get into the GitLab workflow, though I have used it.
> 
> Perhaps I'm the only one, but I don't think we should be mandating this
> (yet?)...

G'Day Martin,

Thanks for the feedback.  I should have checked rather than working on
a 'gut feel' and I see you are still using samba-technical a fair
bit[1].  

I would say that aside from your patches, the vast majority of the
patch flow has moved to GitLab.

To help us present a clear process, do you think you could embrace
GitLab, if not for the benefits to you, but for the sake of our new
contributors?

The alternatives are (to my mind):
 - Contributors get ignored on samba-technical (both because the
patches are not known-good and because they are not on a clear to-do
list)
 - Contributors other than yourself keep getting told off for doing it
'wrong'.

What do you think?

Christof,

You are the other person I still using samba-technical much at all to
submit patches.  Is there anything I can do to help you make the move
to GitLab, or is there anything stopping you?

Thanks,

Andrew Bartlett

[1] Attached is the histogram of patches on samba-technical from April
-> June, for the curious.  

-- 
Andrew Bartlett
https://samba.org/~abartlet/
Authentication Developer, Samba Team         https://samba.org
Samba Development and Support, Catalyst IT   
https://catalyst.net.nz/services/samba



-------------- next part --------------
      1 From: =3D?UTF-8?q?G=3DC3=3DBCnther=3D20Deschner?=3D <gd at samba.org>
      1 From: Aaron Haslett via samba-technical <samba-technical at lists.samba.org>
      1 From: Amitay Isaacs <amitay at gmail.com>
      1 From: Amitay Isaacs <amitay at samba.org>
      1 From: Amitay Isaacs via samba-technical <samba-technical at lists.samba.org>
      1 From: Amit Kumar <amitkuma at redhat.com>
      1 From: Andreas Schneider <asn at samba.org>
      1 From: Andreas Schneider via samba-technical <samba-technical at lists.samba.org>
      1 From: Andrew Walker via samba-technical <samba-technical at lists.samba.org>
      1 From: Anoop C S <anoopcs at redhat.com>
      1 From: Anoop C S via samba-technical <samba-technical at lists.samba.org>
      1 From: Isaac Boukris via samba-technical <samba-technical at lists.samba.org>
      1 From: Jeremy Allison via samba-technical <samba-technical at lists.samba.org>
      1 From: Jones Syue via samba-technical <samba-technical at lists.samba.org>
      1 From: Pavel Shilovsky <piastryyy at gmail.com>
      1 From: P Mairo via samba-technical <samba-technical at lists.samba.org>
      1 From: Richard Sharpe via samba-technical <samba-technical at lists.samba.org>
      1 From: Rikard Falkeborn <rikard.falkeborn at gmail.com>
      1 From: Rikard Falkeborn via samba-technical <samba-technical at lists.samba.org>
      1 From: Robert Sander <r.sander at heinlein-support.de>
      1 From: Robert Sander via samba-technical <samba-technical at lists.samba.org>
      1 From: Stefan Behrens <sbehrens at giantdisaster.de>
      1 From: Stefan Behrens via samba-technical <samba-technical at lists.samba.org>
      1 From: Steve French via samba-technical <samba-technical at lists.samba.org>
      1 From: =?UTF-8?Q?G=c3=bcnther_Deschner?= <gd at samba.org>
      1 From: =?UTF-8?Q?G=c3=bcnther_Deschner?= via samba-technical
      1 From: Volker Lendecke <vl at samba.org>
      2 From: Amit Kumar via samba-technical <samba-technical at lists.samba.org>
      2 From: Anoop C S <anoopcs at redhat.com>
      2 From: Lukas Slebodnik <lslebodn at fedoraproject.org>
      2 From: Lukas Slebodnik via samba-technical <samba-technical at lists.samba.org>
      2 From: Lutz Justen <ljusten at google.com>
      2 From: Ralph Wuerthner via samba-technical <samba-technical at lists.samba.org>
      2 From: Shyam Rathi via samba-technical <samba-technical at lists.samba.org>
      2 From: Tim Beale via samba-technical <samba-technical at lists.samba.org>
      3 From: Douglas Bagnall via samba-technical <samba-technical at lists.samba.org>
      3 From: Rafael David Tinoco via samba-technical <samba-technical at lists.samba.org>
      3 From: Ralph Wuerthner <ralph.wuerthner at de.ibm.com>
      3 From: Rouven WEILER via samba-technical <samba-technical at lists.samba.org>
      3 From: swen via samba-technical <samba-technical at lists.samba.org>
      4 From: Gary Lockyer <gary at catalyst.net.nz>
      4 From: Gary Lockyer via samba-technical <samba-technical at lists.samba.org>
      7 From: Christof Schmitt via samba-technical <samba-technical at lists.samba.org>
     10 From: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
     12 From: Martin Schwenke via samba-technical <samba-technical at lists.samba.org>
     14 From: Tim Beale <timbeale at catalyst.net.nz>
     17 From: Christof Schmitt <cs at samba.org>
     48 From: Martin Schwenke <martin at meltin.net>


More information about the samba-technical mailing list