recent flapping tests

[Douglas Bagnall]

hi Martin,

> Should be fixed by fixes pushed on 7 May.

I can confirm all your "shoulds". Also I can confirm the wisdom of
hedging with this "may":

>>    4 *FAILED* tests/simple/69_recovery_resurrect_deleted.sh
> 
> May be fixed by fixes pushed on 7 May.  :-)

It happened twice since May 8.

The complete results for the last thirty days look like this:

$ ./parse-email/parse-autobuild-email --file-regex sn-devel-184 --since
2019-05-08
found 36 lines matching '(?:^(?:UNEXPECTED|\\*FAILED\\*))|(?:No space left
on device)' in 37 files matching 'sn-devel-184'
   8 UNEXPECTED(failure):
samba.tests.auth_log_winbind.samba.tests.auth_log_winbind.AuthLogTestsWinbind.test_wbinfo(ad_member:local)
   6 UNEXPECTED(failure):
samba.tests.auth_log_winbind.samba.tests.auth_log_winbind.AuthLogTestsWinbind.test_wbinfo_ntlmv1(ad_member:local)
   4 UNEXPECTED(failure):
samba.wbinfo_simple.check-secret.domain=SAMBA-TEST.wbinfo(nt4_member:local)
   3 UNEXPECTED(failure): samba3.raw.notify.mask(nt4_dc)
   2 UNEXPECTED(failure):
samba4.drs.getnc_schema.python(schema_pair_dc).getnc_schema.SchemaReplicationTests.test_schema_linked_attributes(schema_pair_dc)
   2 *FAILED* tests/simple/69_recovery_resurrect_deleted.sh
   2 UNEXPECTED(failure):
samba4.ldap.password_lockout.python(ad_dc_slowtests).__main__.PasswordTestsWithSleep.test_pso_login_lockout_krb5(ad_dc_slowtests)
   2 UNEXPECTED(error):
samba4.drs.samba_tool_drs.python(vampire_dc).samba_tool_drs.SambaToolDrsTests.test_samba_tool_kcc(vampire_dc:local)
   2 UNEXPECTED(failure):
samba4.ldap.notification.python(ad_dc_ntvfs).__main__.LDAPNotificationTest.test_simple_search(ad_dc_ntvfs)
   1 UNEXPECTED(failure):
samba4.ldap.password_lockout.python(ad_dc_slowtests).__main__.PasswordTestsWithSleep.test_login_lockout_krb5(ad_dc_slowtests)
   1 UNEXPECTED(failure):
samba4.winbind.struct.lookup_name_sid(nt4_member:local)
   1 UNEXPECTED(failure): samba3.raw.notify.dir(nt4_dc)
   1 UNEXPECTED(failure): samba3.smb2.notify.mask(nt4_dc)
   1 UNEXPECTED(failure):
samba4.ldap.rodc_rwdc.python(rodc).__main__.RodcRwdcCachedTests.test_login_lockout_krb5(rodc:local)

That makes 36 failures in 120 tests, which is 30%. As ctdb went quiet,
everything else got worse.

Andrew says the top two were fixed a couple of days ago, so you might
think we can expect a failure rate of (36 - 14) / 120 = 18%, but that
isn't quite valid because some of those runs that flapped on the
authlog might have been destined to go on to flap on something else.
It depends on the order in which tests run.

cheers
Douglas