[PATCH 03/12] block: bio_release_pages: use flags arg instead of bool

Christoph Hellwig hch at infradead.org
Wed Jul 24 05:30:53 UTC 2019

On Tue, Jul 23, 2019 at 09:25:09PM -0700, john.hubbard at gmail.com wrote:
> From: John Hubbard <jhubbard at nvidia.com>
> In commit d241a95f3514 ("block: optionally mark pages dirty in
> bio_release_pages"), new "bool mark_dirty" argument was added to
> bio_release_pages.
> In upcoming work, another bool argument (to indicate that the pages came
> from get_user_pages) is going to be added. That's one bool too many,
> because it's not desirable have calls of the form:

All pages releases by bio_release_pages should come from
get_get_user_pages, so I don't really see the point here.

More information about the samba-technical mailing list