[SMB3][PATCH] fix copy_file_range when copying beyond end of source file

Amir Goldstein amir73il at gmail.com
Mon Jul 15 07:50:31 UTC 2019

On Thu, Jul 11, 2019 at 6:19 PM Steve French <smfrench at gmail.com> wrote:
> I noticed that the copy_file_range patches were merged (which is good)
> - see below.
> Anything else to merge for the changes to cifs.ko that we discussed
> earlier.

There was the cifs patch that I sent you:

cifs: copy_file_range needs to strip setuid bits and update timestamps

That was not included in Darrick's branch.

> I wasn't sure about the "SMB3: fix copy file when beyond
> size of source" patch - it may be redundant.  I will need to check

It is redundant, but if you plan to forward a patch to stable, it
will be easier for you to forward just the CIFS patch, so up to you.
I am not sure if and when I will get to testing and forwarding
copy_file_range patches to stable. Not sure it makes sense.

> with current mainline.  Anything else needed for the enabling of
> copy_file_range cross mount etc.

The mtime update patch is not *needed* for enabling of
copy_file_range cross mount. It is a correctness patch.
So copy_file_range cross mount should work in mainline
with cifs as long as other cifs related bugs have been fixed.


More information about the samba-technical mailing list