[PATCH] ctdb-config: depend on /etc/default/nodes file

Martin Schwenke martin at meltin.net
Fri Jul 5 06:44:47 UTC 2019


On Thu,  4 Jul 2019 17:53:55 +0000, Rafael David Tinoco via
samba-technical <samba-technical at lists.samba.org> wrote:

> CTDB should start as a disabled unit (systemd) in most of the
> distributions and, when trying to enable it for the first time, user
> should get an unconfigured, or similar, error.
> 
> Depending on /etc/ctdb/nodes file will give a clear direction to final
> user on what is needed in order to get cluster up and running. It should
> work like previous ENABLED=NO variables in SySV like initialization
> scripts.
> 
> BUG: https://bugzilla.samba.org/show_bug.cgi?id=14026
> 
> Signed-off-by: Rafael David Tinoco <rafaeldtinoco at ubuntu.com>
> ---
>  ctdb/config/ctdb.service | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/ctdb/config/ctdb.service b/ctdb/config/ctdb.service
> index 675b3147417..fd81c38e26d 100644
> --- a/ctdb/config/ctdb.service
> +++ b/ctdb/config/ctdb.service
> @@ -2,6 +2,7 @@
>  Description=CTDB
>  Documentation=man:ctdbd(1) man:ctdb(7)
>  After=network-online.target time-sync.target
> +ConditionFileNotEmpty=/etc/ctdb/nodes
>  
>  [Service]
>  Type=forking

Referencing bug 14017 in commit message instead of duplicate:

Signed-off-by: Martin Schwenke <martin at meltin.net>

peace & happiness,
martin



More information about the samba-technical mailing list