[PATCH] vfs_fruit: Fix potential devide by zero to resolve Time Machine backup max size issue

Kenneth Van Alstyne kvanalstyne at knightpoint.com
Wed Jul 3 15:17:03 UTC 2019

Hello all:
	I recently ran into an issue with Samba 4.10.5 that caused smbd to crash when the "fruit:time machine max size” option was set, but before an initial backup was done in the share, resulting in a divide by zero error.  This has been discussed in detail in the "https://bugzilla.samba.org/show_bug.cgi?id=13622” bugzilla and impacted me on x86_64, so not only armv7l.  The attached patch resolved the issue for me, so can this be reviewed and if deemed appropriate pushed to master and backported to the 4.10 branch?


Kenneth Van Alstyne
Systems Architect
Knight Point Systems, LLC
Service-Disabled Veteran-Owned Business
1775 Wiehle Avenue Suite 101 | Reston, VA 20190
c: 228-547-8045 f: 571-266-3106
DHS EAGLE II Prime Contractor: FC1 SDVOSB Track
GSA Schedule 70 SDVOSB: GS-35F-0646S
GSA MOBIS Schedule: GS-10F-0404Y
ISO 9001 / ISO 20000 / ISO 27001 / CMMI Level 3

Notice: This e-mail message, including any attachments, is for the sole use of the intended recipient(s) and may contain confidential and privileged information. Any unauthorized review, copy, use, disclosure, or distribution is STRICTLY prohibited. If you are not the intended recipient, please contact the sender by reply e-mail and destroy all copies of the original message.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: vfs-fruit-fix-tm-max-size.patch
Type: application/octet-stream
Size: 1386 bytes
Desc: vfs-fruit-fix-tm-max-size.patch
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20190703/0cc8a88c/vfs-fruit-fix-tm-max-size.obj>

More information about the samba-technical mailing list