[PATCH] Some fixes for Solaris CC

swen swen at linux.ibm.com
Wed Jan 30 20:58:11 UTC 2019

On Wed, 2019-01-30 at 21:53 +0100, Volker Lendecke wrote:
> On Wed, Jan 30, 2019 at 09:23:43PM +0100, swen via samba-technical
> wrote:
> > The inner union only has one "member", 
> > is it not easier to just remove the union ?
> > 
> This is something that the authors of this could should comment on. I
> am not the designer of this, and I wanted the minimum necessary
> change
> to get this in.
> > In addition, you could fix the 80 column violation of the lines
> > you're
> > modifying.... ok with the above change not anymore :-)
> Ok, you're right. Normally I modify the 80-col violations in this
> kind
> of patch. This time I opted for the minimum necessary change. I can
> re-submit if that's a problem for you.
Not for me, I have no say in this anyway.
But the minimum necessary change would tbe the removal of the union.

Maybe you should get another opinion on this with more weight.

Cheers Swen.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20190130/1cb8b56d/signature.sig>

More information about the samba-technical mailing list