[PATCH] Some fixes for Solaris CC

swen swen at linux.ibm.com
Wed Jan 30 20:23:43 UTC 2019


Hi Volker
On Wed, 2019-01-30 at 20:52 +0100, Volker Lendecke via samba-technical
wrote:
> Hi!
> 
> Review appreciated!
> 

The inner union only has one "member", 
is it not easier to just remove the union ?

So, like this....

struct ndr_compression_state {
	enum ndr_compression_alg type;
	struct {
		struct z_stream_s *z;
		uint8_t *dict;
		size_t dict_size;
	} mszip;
};

In addition, you could fix the 80 column violation of the lines you're
modifying.... ok with the above change not anymore :-)

Cheers Swen
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20190130/9ebadd18/signature.sig>


More information about the samba-technical mailing list