[PATCH] Fix string to integer conversion
swen at linux.ibm.com
Mon Jan 28 13:43:36 UTC 2019
On Fri, 2019-01-25 at 12:05 -0800, Jeremy Allison via samba-technical
> On Fri, Jan 25, 2019 at 07:20:12PM +0100, swen wrote:
> > Anyhow, as we both stated already, not important enough to
> > bikeshed.
> Well you could always just rework the code
> to do it the 'right' (by my definition of course :-)
> way. That's part of the collaborative process,
> learning to work with others.
Yes, but collaboration is not a one-way street.
... being able to work with others doesn't mean to agree
with everything they say.
> As I said, I
> have strong opinions on the correct API for
> this. If you really think I'm wrong, you
> can get two other engineers to agree with
> We're already bikeshedding this, so we might
> as well finish the paint job :-).
That is actually true :-)
> Doing this the right way would have expended
> much less effort than this argument. I guess
> I don't understand why you're adamant that
> doing a half-assed job of fixing the code
> (by explicitly messing with errno inline)
> is better than using a wrapper function
> that does it correctly (and avoids multiple
> direct manipulation of errno). Remember,
> errno is a global variable - messing with
> it is just nasty.
I know, but it was never about extra work.
It is just a disagreement in what is the right solution.
As for the technical part - global var - yes, that is not the best idea
people had, but it is the way it is and we could make it work the way
we want it. Besides, we weren't in disagreement about whether to use
a wapper or not, but we still are regarding the API you suggested.
> Learning to work with others, even if you
> disagree, will stand you in good stead in
> the future, more than just abandoning
> something as 'too hard to get in'.
That is the point where I might surrender.
I still believe your suggested way is not good a good API.
Anyhow, because I believe that that solution is still better than none,
I will prepare a patch with your code suggestion.
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 833 bytes
Desc: This is a digitally signed message part
More information about the samba-technical